Topic or reply author name isn't correctly decoded in email notifications

[danielbachhuber]

If my user's display name is Super&AwesomeDaniel (on the frontend, or Super&AwesomeDaniel in the database), then a forum or topic email notification be sent with:

Super&AwesomeDaniel wrote:

I would expect it to display:

Super&AwesomeDaniel wrote:

My hacky workaround is:

add_filter( 'bbp_subscription_mail_message', function( $message ){
	$bits    = explode( PHP_EOL, $message );
	$bits[0] = html_entity_decode( $bits[0], ENT_QUOTES );
	$message = implode( PHP_EOL, $bits );
	return $message;
});

[johnjamesjacoby]

Try wp_specialchars_decode() on author names

[danielbachhuber]

@johnjamesjacoby Yep, wp_specialchars_decode() seems to work too.

[johnjamesjacoby]

In 6904:

Subscriptions: ensure special characters in author names are encoded properly.

This commit copies the approach used on the content, and applies wp_specialchars_decode() and strip_tags() to author names in subscription emails.

(HTML tags are not usually allowed in usernames, but we strip them anyways in the event a filter allowed them. Better to keep emails legible than include unintended tags?)

Fixes #3256.

[johnjamesjacoby]

#3251 was marked as a duplicate.