Skip to:
Content

bbPress.org

Opened 7 years ago

Closed 7 years ago

#3248 closed enhancement (fixed)

Disable email notifications when WP_IMPORTING=true

Reported by: danielbachhuber's profile danielbachhuber Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.0
Component: API - Subscriptions Keywords: commit
Cc:

Description

As a sanity check against sending unexpected emails, bbPress should bail early if the WP_IMPORTING constant is defined to true.

I think subscriptions are the only feature impacted by this.

Change History (2)

#1 @johnjamesjacoby
7 years ago

  • Component changed from General to API - Subscriptions
  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Version set to 2.0

Good call. Easy change.

#2 @johnjamesjacoby
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6898:

Subscriptions: do not send subscription emails during WordPress imports.

This change adds checks to the WP_IMPORTING global constant inside of forum & topic subscription notification functions, to prevent sending emails during the import process.

Because hooks still fire during imports, this sanity check avoids a potentially hugely annoying situation for users during forum migrations by any import tool that obeys the use of this core constant.

Fixes #3248. Props danielbachhuber.

Note: See TracTickets for help on using tickets.