Unapproved stickies still listed in forums

[bbrian]

If a sticky is unapproved, it does not remove it from the top of the forum's list of topics. Regular users can see the sticky title but reach a 404 page when trying to open it.

To reproduce:

<?php
$topic_id = <non-sticky test topic id>;

bbp_stick_topic( $topic_id, true );

bbp_unapprove_topic( $topic_id );

...then view the forum as a regular user to confirm the sticky is still listed.

I'm using bbp_unstick_topic( $topic_id ); after calling bbp_unapprove_topic() but this loses the historical context of the stickied post.

Version 2.6-rc-7.

[johnjamesjacoby]

In 6915:

Stickies: make sure unapproved topics are unstuck also.

This commit removes a hard coded call to bbp_unstick_topic() and hooks into the neighboring bbp_stick_topic action, while also hooking into the bbp_unapprove_topic action.

A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code.

Fixes #3246.