Skip to:
Content

bbPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 15 months ago

#3242 closed defect (bug) (fixed)

PHP 7.3 Compat: Continue Targeting Switch issues Warning

Reported by: rebasaurus's profile rebasaurus Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: highest omg sweet tea
Severity: major Version:
Component: General Keywords: needs-patch
Cc:

Description

In [includes/admin/parser.php](​https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/parser.php#L225) on lines 225, 237 and 241,

continue statements targeting switch control flow structures will now generate a warning. In PHP such
continue statements are equivalent to break, while they behave as continue 2 in other languages.

See ​http://php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.continue-targeting-switch

Change History (6)

#1 @johnjamesjacoby
6 years ago

  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby

​Kunena needed to fix this also.

#2 @johnjamesjacoby
6 years ago

We maintain a fork of NBBC on GitHub, so I'll get this fixed up over there.

​https://github.com/bbpress/NBBC

#3 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6887:

Parser: Fix PHP 7.3 warning ("continue" in "switch" is equal to "break")

Fixes #3242.

#4 @rebasaurus
6 years ago

@johnjamesjacoby Thanks! Any chance this can make it to an upcoming RC or the current RC?

Version 0, edited 6 years ago by rebasaurus (next)

#5 @johnjamesjacoby
6 years ago

@rebasaurus It definitely will make it into the next RC. Thank you for bringing this up here. I really appreciate it.

Note: See TracTickets for help on using tickets.