Skip to:
Content

bbPress.org

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#3228 closed defect (fixed)

CSS Coding Standard - Use double quotes

Reported by: jrf Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: Appearance - Included Themes Keywords:
Cc:

Description

I've just tried to run npm install and then grunt build on the current trunk and am getting the following errors:

First one:

Loading "sass.js" tasks...ERROR
>> SyntaxError: Unexpected token (

I've looked over the file in trunk/node_modules/grunt-sass/tasks/sass.js, but didn't see anything I wouldn't expect, so not sure what's going on there.

Second one:

Running "stylelint:css" (stylelint) task

src/templates/default/css/bbpress.css
 163:11  ×  Expected double quotes   string-quotes

? 1 problem

Patch attached to the ticket.

Third one:

Warning: Task "sass:colors" not found. Use --force to continue.

Attachments (1)

trac-3228-css-quotes.patch (410 bytes) - added by jrf 11 months ago.
Fixes the error thrown by the stylelint:css task

Download all attachments as: .zip

Change History (5)

@jrf
11 months ago

Fixes the error thrown by the stylelint:css task

#1 @netweb
11 months ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6873:

Styling: Use double quotes

Fixes #3228.
Props jrf.

#2 @jrf
11 months ago

Just in case anyone else comes across this issue:

Ok, so with the help of @netweb, we managed to figure out that the other two errors I was receiving had to do with an out-of-date version of node.js, which npm wasn't warning about when doing an npm install.
Upgrading to Node 10.13.0 fixed those issues.

#3 @netweb
11 months ago

  • Component changed from Tools - Build to Appearance - Included Themes
  • Milestone changed from Awaiting Review to 2.6
  • Summary changed from grunt build currently broken to CSS Coding Standard - Use double quotes

Thanks @jrf, I've updated the title per the commit and patch, thanks again 😄

Note: See TracTickets for help on using tickets.