Skip to:
Content

bbPress.org

Changes between Initial Version and Version 9 of Ticket #3217


Ignore:
Timestamp:
09/06/2018 02:49:38 AM (7 years ago)
Author:
netweb
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3217

    • Property Status changed from new to reopened
    • Property Component changed from General to Appearance - Theme Compatibility
    • Property Owner set to johnjamesjacoby
    • Property Milestone changed from Awaiting Review to 2.6
    • Property Keywords commit added

  • Ticket #3217 – Description

    initial v9  
    1 Since commit #6628 the forums list is generating invalid HTML. The list is in a UL with each forum being a LI. However, the change was made and it is generating the comma separator outside the LI tag which is not allowed in the HTML spec.
     1Since commit [6628] the forums list is generating invalid HTML. The list is in a UL with each forum being a LI. However, the change was made and it is generating the comma separator outside the LI tag which is not allowed in the HTML spec.
    22
    33A tentative fix might be as follows, it seems to work for us here, but however the devs handle it is fine. :)  I left the old code in place as a reference.
    … …  
    66
    77{{{
     8#!php
     9<?php
    810 758                 // Build this sub forums link
    911 759                 // $links[] = $r['link_before'] . '<a href="' . esc_url( $permalink ) . '" ' . $subforum_classes_attr . '>' . $title . $counts . '</a>' . $r['link_after'];