Skip to:
Content

bbPress.org

Changes between Initial Version and Version 1 of Ticket #3217, comment 10


Ignore:
Timestamp:
09/18/2018 01:58:44 AM (7 years ago)
Author:
scmsteve
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3217, comment 10

    initial v1  
    1 My concern about this change is the note "revert default mark-up back to div's and span's", whereas in the version 2.5 that we were running, they **weren't**  div and span tags, but where ul and li tags. The issue is that before, the comma was inside the li and the change put it outside the li. But the change was not making div and span into ul and li. This change broke our display and our css, as the selectors are all different, and the div/span combo does not display like a ul/li combo does. So, when was this done with div and span, because it seems it was before the 2.6 changes.
     1My concern about this change is the note "revert default mark-up back to div's and span's", whereas in the version 2.5 that we were running, they **weren't**  div and span tags, but where ul and li tags. The issue is that before, the comma was inside the li and the change put it outside the li. But the change was not making div and span into ul and li. This change broke our display and our css, as the selectors are all different, and the div/span combo does not display like a ul/li combo does. So, when was this done with div and span, because it seems it was before the 2.6 changes.  EDIT: I just looked, it was UL/LI in 2.0 so it has been a long time. I expect, if this was customized by many, or even not, there will be a lot of site design breakage by moving to DIV/SPAN here.