Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3214 closed defect (bug) (duplicate)

Incorrect value passed for mark reply in buddypress

Reported by: seennothurd's profile seennothurd Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: Priority: normal
Severity: normal Version: 2.5
Component: Extend - BuddyPress Keywords: commit
Cc:

Description

includes/extend/buddypress/notifications.php:213

Either the function should be changed to bbp_get_topic_url or the passed value should be $reply_id

Change History (3)

#1 @johnjamesjacoby
8 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Version changed from trunk to 2.5

#2 @johnjamesjacoby
8 years ago

  • Milestone 2.6 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Will fix in #3213.

#3 @johnjamesjacoby
8 years ago

In 6845:

BuddyPress: use $reply_id instead of $topic_id so bbp_get_reply_url() works correctly.

This change ensures that notification links go directly to the reply, not the topic, and not a 404.

Fixes #3213. See #3214.

Note: See TracTickets for help on using tickets.