Incorrect value passed for new reply notification in buddypress

[seennothurd]

The value passed into the item_id key of the array of args for bp_notifications_add_notification (includes/extend/buddypress/notifications.php:149) does not match the value expected for the notification formatting (includes/extend/buddypress/notifications.php:70).

The value the formatting function expects is the reply ID. The value passed along from the bp_notifications_add_notification function is the topic ID of that reply. This means the bbp_get_reply_url function returns a useless url, which in the case of Buddypress causes an redirect loop.

This means users cannot get to the new reply as notified.

[johnjamesjacoby]

In 6845:

BuddyPress: use $reply_id instead of $topic_id so bbp_get_reply_url() works correctly.

This change ensures that notification links go directly to the reply, not the topic, and not a 404.

Fixes #3213. See #3214.

[johnjamesjacoby]

This change has caused bbp_buddypress_mark_notifications() to stop working as intended.

Or bbp_format_buddypress_notifications() is using the wrong ID to create the wrong URL.

Going to reopen this to look into it further for 2.6.6.

[johnjamesjacoby]

In 7109:

BuddyPress: Mark all replies when marking topic notifications as read.

This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.

In branches/2.6, for 2.6.6.

Fixes #3213.

[rimanil]

Resolution set to fixed
Status changed from reopened to closed