Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

#3193 closed defect (bug) (fixed)

BuddyPress: Use custom includes() method

Reported by: r-a-y Owned by: johnjamesjacoby
Priority: normal Milestone: 2.6
Component: Extend - BuddyPress Version: 2.1
Severity: normal Keywords: has-patch
Cc:

Description

For BuddyPress support, bbPress extends the BP_Component class.

However, with the way the BP_Component::includes() method is coded and how bbPress has its BuddyPress file structure, on every pageload, there are 15 is_file() checks that fail for the BBP_Forums_Component() class:
​https://buddypress.trac.wordpress.org/browser/tags/2.9.3/src/bp-core/classes/class-bp-component.php?marks=366-374,378#L355

Attached patch fixes this by adding our own includes() routine instead of inheriting BP's one.

Attachments (1)

3193.01.patch​ (633 bytes ) - added by r-a-y 8 years ago.

Download all attachments as: .zip

Change History (3)

@r-a-y
8 years ago

#1 @johnjamesjacoby
8 years ago

  • Milestone Awaiting Review → 2.6

#2 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution → fixed
  • Status new → closed

In 6807:

BuddyPress: more efficient includes method.

Props r-a-y. Fixes #3193.

Note: See TracTickets for help on using tickets.