Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

#3162 closed regression (fixed)

bbp_get_topic_pagination_count filter no longer allows HTML

Reported by: peterwsterling Owned by: johnjamesjacoby
Priority: normal Milestone: 2.6
Component: API - Actions/Filters Version:
Severity: normal Keywords: commit
Cc:

Description

The bbp_get_topic_pagination_count filter used to allow HTML to be inserted. These are now being encoded, e.g. <span> becomes &lt;span&gt;. This is all very well, but it makes it impossible to style the output using CSS.

Change History (3)

#1 @peterwsterling
9 years ago

Oops, BTW this is in Version 2.6-rc-3

#2 @johnjamesjacoby
9 years ago

  • Keywords commit added; dev-feedback removed
  • Owner set to johnjamesjacoby
  • Type defect → regression

Confirmed.

This is not intentional. Fix imminent for 2.6.

#3 @johnjamesjacoby
9 years ago

  • Resolution → fixed
  • Status new → closed

In 6682:

Template: adjust escaping of pagination count strings.

This change fixes a regression (in trunk only) that caused the filtered results of pagination counts to always be late escaped, but the intention was really only to escape the output of _n() which does not have an escaped equivalent function in the Gettext API.

I also tweaked the logic in bbp_get_topic_pagination_count() to not bail early. This brings it inline with bbp_get_forum_pagination_count() and allows the filter to run even when the text string is empty. Flexibility is the goal, so skipping the filter was also unintentional, and is now fixed.

Fixes #3162.

Note: See TracTickets for help on using tickets.