Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3158 closed defect (bug) (fixed)

Disabling post formatting generates <b>Notice</b>: Undefined index: tab

Reported by: vinod dalvi Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: General - Content Creation Keywords: has-patch commit
Cc:

Description

Disabling "post formatting" option generates following notice in the topic editor in front end

<b>Notice</b>:  Undefined index: tab in <b>/opt/lampp/htdocs/wordpress/wp-content/plugins/bbpress/includes/common/template.php</b> on line <b>2030</b><br />
>

Steps to reproduce the issue :

In the site admin area go to Settings -> Forums
Uncheck the plugin option "Add toolbar & buttons to textareas to help with HTML formatting"
Then visit site front end to create topic
You will see notice in the topic editor as shown in the attached screenshot

Attachments (2)

Screenshot (15).png (51.0 KB) - added by vinod dalvi 4 years ago.
Screenshot of the issue
3158.patch (956 bytes) - added by vinod dalvi 4 years ago.
Patch to resolve the issue.

Download all attachments as: .zip

Change History (7)

@vinod dalvi
4 years ago

Screenshot of the issue

@vinod dalvi
4 years ago

Patch to resolve the issue.

#1 @vinod dalvi
4 years ago

  • Keywords needs-testing added

#2 @johnjamesjacoby
4 years ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby

Confirmed.

Thanks a lot for the patch, too! I'll give this a look, and get in committed asap.

#3 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Content: Use correct tabindex array key vs. tab.

This change corrects a debug notice when the TinyMCE toolbar setting is toggled off.

Trunk, for 2.6. See r6424. Props vinod-dalvi.

#4 @vinod dalvi
4 years ago

@johnjamesjacoby I don't see it is resolved in https://bbpress.trac.wordpress.org/changeset/6424

Note: See TracTickets for help on using tickets.