Skip to:
Content

bbPress.org

Changes between Initial Version and Version 1 of Ticket #3125, comment 1


Ignore:
Timestamp:
07/06/2017 11:55:57 AM (4 years ago)
Author:
espellcaste
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3125, comment 1

    initial v1  
    11I'm in favor of 1 and not 2. I see bbp_get_topic_id as a topic id catcher, not a catch, decides what it is and then returns what it comes with it.
    22
    3 bbp_is_topic was not used in the first place because of performance concerns, so unless a performant cralwer is introduced, let's try to minize the hit on a highly used function.
     3bbp_is_topic was not used in the first place because of performance concerns, so unless a performant crawler is introduced, let's try to minimize the hit on a highly used function.
    44
    55What do you think?