User's topic/reply count functions can return false instead of an integer

[SergeyBiryukov]

The following functions are supposed to always return an integer, but can return false if the passed $user_id is empty:

• bbp_get_user_topic_count_raw()
• bbp_get_user_reply_count_raw()
• bbp_get_user_closed_topic_count()

Either the functions should be changed to always return an integer (to match what @return says), or false should be documented as another possible @return value.

[johnjamesjacoby]

Good call. I've been meaning to get rid of the count_user_posts() usages anyways, because they're ineffective for our use case (multiple statuses, etc...)

[johnjamesjacoby]

In 6609:

Counts: Remove count_user_posts() usages, and always return an int.

User topic & reply counts haven't included closed status for topics, and these wrappers should include support for things like view=all later.

Fixes #3124.

[SergeyBiryukov]

In 6610:

Counts: Fix typo in DB query in bbp_get_user_reply_count_raw().

See #3124.