Skip to:
Content

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3112 closed defect (duplicate)

SMF converter replaces <br /> with <tt>

Reported by: vmbellamy Owned by: johnjamesjacoby
Milestone: Priority: normal
Severity: normal Version: 2.5.13
Component: API - Importers Keywords:
Cc:

Description

Dear Sirs and/or Madames,

With the latest version of bbPress, I noticed that the importer kept adding the <tt> tag in my test import of a SMF forum. So, I looked in the source code and found that on line 723 of SMF.php, it reads this:

		$SMF_markup = preg_replace( '/\<br \/\>/',   '<tt>',  $SMF_markup );

it should read this:

		$SMF_markup = preg_replace( '/\<br \/\>/',   '<br />',  $SMF_markup );

though maybe not, as the comment above reads

// Replace '<br />' with ''

Change History (4)

#1 @johnjamesjacoby
2 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby
  • Priority changed from normal to high

Sorry about that. I'll get this fixed, and check out the others for similar issues.

#2 @johnjamesjacoby
2 years ago

  • Keywords needs-patch commit removed
  • Milestone 2.6 deleted
  • Priority changed from high to normal
  • Resolution set to duplicate
  • Severity changed from major to normal
  • Status changed from new to closed

Looks like this was fixed in trunk but not ported to the 2.5 branch. I'll handle that.

If you are able, please consider using one of the 2.6 beta's. The converter has loads of improvements, so it's worth giving it a try instead.

Related: r5332, #2558

#3 @johnjamesjacoby
2 years ago

In 6476:

Converters: Port r5332 to 2.5 branch.

See #2558, #3112.

#4 @johnjamesjacoby
2 years ago

(I looked into the other converters for obvious copy/paste errors, and they look OK.)

Note: See TracTickets for help on using tickets.