Remove EOF closing ?> tags

[ellipszist]

page-forum-statistics.php Line 58
​https://bbpress.trac.wordpress.org/browser/trunk/src/templates/default/extras/page-forum-statistics.php#L58

single-reply-move.php Line 32
​https://bbpress.trac.wordpress.org/browser/trunk/src/templates/default/extras/single-reply-move.php#L32

[milindmore22]

Added closing tags

[milindmore22]

Although It's unnecessary but all other templates have a closing tag at the end, submitted a patch to cover both files.

[Otto42]

Actually, end of PHP files should not have closing tags, because of spaces after then potentially creating header already sent errors.

[johnjamesjacoby]

Otto is correct. The correct thing to do here is remove all of the very last closing PHP tags, preferably with an empty line at the end to prevent Subversion from showing the "No new line at end of file" output.

[netweb]

I've renamed the ticket "Remove EOF closing ?> tags"

Previously #1850 / r3964

A quick search reveals he following "extras" templates all include closing EOF ?> PHP tags that we should remove:

src/templates/default/extras/archive-forum.php
src/templates/default/extras/archive-forum.php
src/templates/default/extras/page-create-topic.php
src/templates/default/extras/page-front-forums.php
src/templates/default/extras/page-front-topics.php
src/templates/default/extras/page-topic-tags.php
src/templates/default/extras/page-user-login.php
src/templates/default/extras/page-user-lost-pass.php
src/templates/default/extras/page-user-register.php
src/templates/default/extras/page-user-register.php
src/templates/default/extras/single-forum-edit.php
src/templates/default/extras/single-forum.php
src/templates/default/extras/single-reply-edit.php
src/templates/default/extras/single-reply.php
src/templates/default/extras/single-topic-edit.php
src/templates/default/extras/single-topic-merge.php
src/templates/default/extras/single-topic-split.php
src/templates/default/extras/single-topic.php
src/templates/default/extras/single-user-edit.php
src/templates/default/extras/single-user.php
src/templates/default/extras/single-view.php
src/templates/default/extras/taxonomy-topic-tag-edit.php
src/templates/default/extras/taxonomy-topic-tag.php

[milindmore22]

Patch will remove all closing tags from extra templates added new line to prevent Subversion from showing the "No new line at end of file" output.

[milindmore22]

Submitted patch with removing all closing tag listed.

but PHP is an embeddable scripting language designed to allow you to embed logic in the form of PHP scripting into content, which is typically HTML. In that context, the opening and closing tags make sense, such as in WordPress' theme template files and all template files are having closing tags.

eg: ​https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyfifteen/single.php

any thoughts on this?

[netweb]

I've just read ​#WP12307 / ​core:changeset:19712, see also ​#WP23505 ​core:changeset:28678 ​#WP30534 ​core:changeset:34887

And my take away summaries from that are:

1. It is now (previously before the above WP ticket it was not) WordPress coding standard to exclude closing PHP tags on files that are not expected to be edited. That includes a theme's functions.php and wp-config.php.

2. Omitting from the r19712 commit is any changes to themes, i.e wp-content/themes/*, as such at the time, and still till today twenty ten and eleven still contain closing tags

The ​PHP coding standards state:

"Omitting the closing PHP tag at the end of a file is preferred. If you use the tag, make sure you remove trailing whitespace."

And from the PHP manual: ​https://secure.php.net/manual/en/language.basic-syntax.phptags.php

"If a file is pure PHP code, it is preferable to omit the PHP closing tag at the end of the file. This prevents accidental whitespace or new lines being added after the PHP closing tag, which may cause unwanted effects because PHP will start output buffering when there is no intention from the programmer to send any output at that point in the script."

I've created a new core ticket ​#WP40039 to discuss the removal of closing PHP tags from the bundled themes

[johnjamesjacoby]

Seems a-OK to commit -1.diff.

Should double check that it covers all of our template parts.

Thanks @milindmore22 for helping!

[johnjamesjacoby]

In 6366:

General: Remove end-of-file ?> tags from extra templates.

These templates are theme drop-ins, and apparently were missed in previous clean-up efforts.

Props milindmore22. Fixes #3078.

[netweb]

In 6371:

General: Following [6366] use a single blank line for end-of-file extras templates.

See #3078.