Opened 8 years ago
Last modified 21 months ago
#3058 new enhancement
Consider bundling WP-CLI commands with bbPress proper
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.7 | Priority: | high |
Severity: | normal | Version: | 2.1 |
Component: | Tools | Keywords: | needs-patch early needs-unit-tests |
Cc: |
Description
I'm curious why bbPress' WP-CLI commands are being developed as a separate package, and not bundled with WP-CLI proper?
Change History (15)
#2
@
8 years ago
- Component changed from General to Tools
- Keywords needs-patch added
Agree. We should merge them eventually, and make sure they're still properly isolated.
#3
@
8 years ago
- Keywords early needs-unit-tests added
- Milestone changed from Future Release to 2.7
- Owner set to netweb
- Priority changed from normal to high
- Version set to 2.1
Let's scoot this to 2.7, and early.
To do:
- Merge what's in @netweb's GitHub repo
- Extract what's in
/admin/tools/repair.php
- Extract what's in
/admin/tools/upgrade.php
- Decide where these should live (in
/includes/cli/
or in/includes/topics/cli.php
) - Ya know, unit tests for all of them
This ticket was mentioned in Slack in #bbpress by jjj. View the logs.
8 years ago
#5
@
8 years ago
- Owner changed from netweb to espellcaste
Assigning to Renato Alves, per: https://wordpress.slack.com/archives/C02RQBYSJ/p1505484663000406
#7
@
7 years ago
Guys! For our first proof of concept. We have something to work with.
We have a stable version here: https://github.com/bbpress/wp-cli-bbpress/pull/4
This PR only will work if #3173 and #3174 is applied.
So to recap:
Done - Merge what's in @netweb's GitHub repo
Done - Extract what's in /admin/tools/repair.php
Done - Extract what's in /admin/tools/upgrade.php
Decide where these should live (in /includes/cli/ or in /includes/topics/cli.php)
I'd rather it stay in the /includes/cli/ folder. This is how WooCommerce has their cli commands and possibly where BuddyPress will keep theirs.
Need help - Ya know, unit tests for all of them
Behat tests is not my strongest suite. So if anyone has more experience with it, please, I'd love to talk to you.
#9
@
7 years ago
Hi! Just passing by to say that I've recently finished the wp-cli-bbpress implementation.
We have a stable version with coverage for several commands: topic, reply, forum, tools, etc. 90% of commands have behat tests.
You can see the code here: https://github.com/bbpress/wp-cli-bbpress
I would encourage the Core team to take a look and see where things could be improved. I'm open to the suggestion of new commands to be introduced.
Thank you! :)
#10
@
7 years ago
Passing by to inform the wp cli package was updated to use namespaces, the same as its brother package, wp-cli-buddypress.
#11
@
6 years ago
Passing by to inform core devs that this package is awesome! You try running those pesky tools via the admin area with millions of topics/replies and see how far you get without this :)
Simply because I had to start somewhere :)
Having now read more docs over the weekend I see that repo becoming a bbPress "feature project" to be merged into bbPress core at some stage ;)