Skip to:
Content

bbPress.org

Opened 3 years ago

Last modified 3 years ago

#3033 new defect

Add PHP 7 compatibility for existing bbpress sites

Reported by: xknown Owned by: xknown
Milestone: Future Release (Legacy) Priority: normal
Severity: normal Version:
Component: General Keywords:
Cc:

Description

There are a few compile time errors in the codebase as well as a bunch of deprecated notices when bbpress is used under PHP 7.

This happens on the latest bbpress version (see #2973) as well as the 1.1 and 1.2 branches.

Change History (25)

#1 @xknown
3 years ago

In 6153:

Add PHP 5.x style constructors.

Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.

See #3033

#2 @xknown
3 years ago

In 6154:

Fix PHP 7 compat issue.

  • func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code is compatible with older PHP versions.
  • Add also PHP 5.x style constructors.

See #3033

#3 @xknown
3 years ago

In 6155:

Fix PHP7 parse error.

The result of new can't be longer assigned by reference.

See #3033

#4 @xknown
3 years ago

In 6156:

Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.

See #3033

#5 @netweb
3 years ago

  • Milestone changed from Awaiting Review to Future Release (Legacy)
  • Owner set to xknown

#6 @xknown
3 years ago

In 6157:

Add PHP 5.x style constructors.

Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.

See #3033

#7 @xknown
3 years ago

In 6158:

Branch 0.9: use a more recent version of add_query_arg which reduces the use of func_get_arg.

See #3033

#8 @xknown
3 years ago

In 6159:

Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.

See #3033

#9 @xknown
3 years ago

In 6160:

Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of func_get_arg() and PHP 5.x constructors.

  • func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
  • Add PHP 5.x style constructors.
  • Use preg_match instead of eregi

See #3033

#10 @xknown
3 years ago

In 6161:

Branch 0.9: Use preg_match instead of ereg

See #3033

#11 @xknown
3 years ago

In 6162:

Branch 0.9: Remove all the expressions that use the preg_replace function with the e modifier.

The e(val) modifier is not longer supported in PHP7, use preg_replace_callback instead.
See #3033

#12 @xknown
3 years ago

In 6163:

Branch 1.2: Fix parse errors in PHP 7

The result of new can't be longer assigned by reference.
See #3033

#13 @xknown
3 years ago

In 6164:

Add PHP 5.x style constructors.

Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033

#14 @xknown
3 years ago

In 6165:

Branch 1.2: Fix PHP 7 compat issue.

  • func_get_arg() returns the current (modified) value of the given argument.
  • Add also PHP 5.x style constructors.

See #3033

#15 @xknown
3 years ago

In 6166:

Fix PHP7 parse error.

The result of new can't be longer assigned by reference.

See #3033

#16 @xknown
3 years ago

In 6167:

Branch 1.2: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.

See #3033

#18 @johnjamesjacoby
3 years ago

In 6169:

Tag bbPress 1.2.1 which adds some basic PHP7 compatibility. See #3033

#19 follow-up: @xknown
3 years ago

In 6170:

branch 0.9: Silence signature mismatch notices.

In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict

See #3033

#20 in reply to: ↑ 19 @xknown
3 years ago

Replying to xknown:

In 6170:

branch 0.9: Silence signature mismatch notices.

In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict

See #3033

Wrong branch mentioned on the above commit message, it should bes/branch 0\.9/branch 1.1/.

#21 @xknown
3 years ago

In 6171:

branch 0.9: Silence signature mismatch notices.

In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict

See #3033

#22 @xknown
3 years ago

In 6205:

branch 1.1: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033

#23 @xknown
3 years ago

In 6206:

branch 0.9: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033

#24 @xknown
3 years ago

In 6207:

branch 1.2: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033

#25 @xknown
3 years ago

In 6209:

branch 1.2: Fix infinite loop when create a new WP_User instance.

See #3033

Note: See TracTickets for help on using tickets.