Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 4 years ago

#3013 closed defect (fixed)

bbp_enqueue_script() $in_footer parameter should be boolean

Reported by: thebrandonallen Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: Appearance - Theme Compatibility Keywords: has-patch
Cc:

Description

Looks like some copy-pasta made it's way into bbp_enqueue_script(). The $in_footer parameter should be a boolean. However, bbPress uses this parameter the same way it's used by (bbp|wp)_enqueue_style, by passing a media query string. Attached patch updates the default value, and it's usage to a boolean. Whether on purpose, or inadvertently, our scripts where being added in the footer, so the attached patch explicitly maintains this behavior.

Related #3012

Attachments (1)

3013.diff​ (1.2 KB) - added by thebrandonallen 4 years ago.

Download all attachments as: .zip

Change History (2)

@thebrandonallen
4 years ago

#1 @netweb
4 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6112:

Theme Compatibility: Parameter $in_footer in bbp_enqueue_script() should be boolean.

This changeset updates copy-pasta introduced in [5181], bbp_enqueue_script() is a wrapper for wp_enqueue_script(), $in_footer boolean parameter introduced in ​wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior.

Props thebrandonallen.
Fixes #3013.

Note: See TracTickets for help on using tickets.