Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 9 years ago

#2960 closed defect (bug) (fixed)

Plurals may be incorrect in "Right Now" dashboard widget

Reported by: thebrandonallen's profile thebrandonallen Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.0
Component: Locale - i18n/l10n Keywords: has-patch
Cc:

Description

This is the same issue as in #1683, but for the plugin instead of legacy forums.

To summarize, in the "Right Now" dashboard widget a i18n formatted number is passed to _n(). If the formatted number includes a separator, and the number before the separator is a one, then _n() will believe that the count is 1, and return the singular version of the string.

Examples:
1,000 => singular version of the string
2,000 => plural version of the string

Attachments (3)

incorrect_counts_with_odd_before_separator.png​ (18.0 KB) - added by thebrandonallen 10 years ago.
2960.1.patch​ (8.0 KB) - added by thebrandonallen 10 years ago.
2960.2.patch​ (11.0 KB) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (5)

@thebrandonallen
10 years ago

@thebrandonallen
10 years ago

@netweb
10 years ago

#1 @netweb
10 years ago

Related: ​#WP8324

2960.2.patch​ is a refresh of 2960.1.patch​ using bbPress' bbp_number_format_i18n wrapper for number_format_i18n (no other changes)

#2 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6227:

Akismet: Improve pluralization of statistics strings.

Fixes #2960. Props thebrandonallen, netweb.

Note: See TracTickets for help on using tickets.