bbp_forum_query_last_reply_id and bbp_update_forum_reply_count queries too long

[tharsheblows]

This is a number of characters issue. Those queries are getting killed because they have so many topic ids in them, one is currently 16833 characters long (over 2000 topics). I have fairly robust hosting so think this might be an issue for other people too?

I'm curious to know if anyone else is running into it - the number of topics and replies will be the same(ish) in eg the forums list and it won't be fixable in the tools. Or if there's another ticket open on it, I can't find one but that doesn't mean it's not there!

[tharsheblows]

run through chunked topic_id arrays

[tharsheblows]

I've just done the topic_ids in batches of 1000. I have a feeling this isn't the best way for everyone but it works for me and makes a decent starting point.

[tharsheblows]

Adds in empty array if $topic_ids starts off empty -- this allows it to run through WP_Query at least once which it needs. (+1 for good unit tests! I forgot to run them earlier. :) )

[tharsheblows]

adds in empty array to chunk array if that's empty

[johnjamesjacoby]

Inadvertently fixed this for 2.6 in a few different ways, namely using no_found_rows.

This shouldn't be an issue anymore, so closing.

If it's still a problem, let's reopen & pursue.