Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 4 years ago

#2912 closed defect (fixed)

Avoid using HTML tags in translation strings (includes/admin/replies.php)

Reported by: ramiy Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Locale - i18n/l10n Keywords: has-patch
Cc:

Description

In this ticket, we simplify the translation strings, like we did in wordpress core. Removing the HTML tags from translation strings to make the translation process faster and easier.

See the attached patch.


Old strings:

  • Reply updated. <a href="%s">View topic</a>
  • Reply created. <a href="%s">View topic</a>
  • Reply submitted. <a target="_blank" href="%s">Preview topic</a>
  • Reply draft updated. <a target="_blank" href="%s">Preview topic</a>

New strings:

  • Reply updated.
  • Reply created.
  • Reply submitted.
  • Reply draft updated.
  • View topic
  • Preview topic

Attachments (3)

2912.patch (2.0 KB) - added by ramiy 4 years ago.
2912.2.patch (2.0 KB) - added by thebrandonallen 4 years ago.
2912.2.2.patch (2.4 KB) - added by thebrandonallen 4 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
4 years ago

#1 @ramiy
4 years ago

Related: #2881

#2 @ramiy
4 years ago

Related: #2910

#3 @ramiy
4 years ago

Related: #2911

#4 @thebrandonallen
4 years ago

  • Milestone changed from Awaiting Review to 2.6

Refresh patch to apply cleanly on trunk.

#5 @netweb
4 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 6045:

i18n: Avoid using HTML tags in translation strings (includes/admin/replies.php)

Props ramiy, thebrandonallen
Fixes #2912

Note: See TracTickets for help on using tickets.