Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

#2910 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (includes/admin/topics.php)

Reported by: ramiy Owned by: netweb
Priority: normal Milestone: 2.6
Component: Locale - i18n/l10n Version:
Severity: normal Keywords: has-patch
Cc:

Description

In this ticket, we simplify the translation strings, like we did in ​wordpress code. Removing the HTML tags from translation strings to make the translation process faster and easier.

See the attached patch.

Old strings:

  • Topic updated. <a href="%s">View topic</a>
  • Topic created. <a href="%s">View topic</a>
  • Topic submitted. <a target="_blank" href="%s">Preview topic</a>
  • Topic draft updated. <a target="_blank" href="%s">Preview topic</a>

New strings:

  • Topic updated.
  • Topic created.
  • Topic submitted.
  • Topic draft updated.
  • View topic
  • Preview topic

Attachments (3)

2910.patch​ (2.0 KB ) - added by ramiy 10 years ago.
2910.02.patch​ (2.5 KB ) - added by thebrandonallen 10 years ago.
2910.03.patch​ (2.0 KB ) - added by thebrandonallen 10 years ago.

Download all attachments as: .zip

Change History (9)

@ramiy
10 years ago

#1 @ramiy
10 years ago

Related: #2881

#2 @ramiy
10 years ago

Related: #2911

#3 @ramiy
10 years ago

Related: #2912

#4 @thebrandonallen
10 years ago

  • Milestone Awaiting Review → 2.6

Updates patch to apply cleanly on latest trunk. Also, removes more HTML and adds one new string:

Topic scheduled for: %s.

This brings us in line with the way WP handles scheduled posts in the admin.

@thebrandonallen
10 years ago

#5 @thebrandonallen
10 years ago

Remove new string from patch, as this is handled in #2881.

@thebrandonallen
10 years ago

#6 @netweb
10 years ago

  • Owner set to netweb
  • Resolution → fixed
  • Status new → closed

In 6043:

i18n: Avoid using HTML tags in translation strings (includes/admin/forums.php)

Props ramiy, thebrandonallen
Fixes #2910

Note: See TracTickets for help on using tickets.