Skip to:

Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#2900 closed enhancement (fixed)

Separator argument not normalized

Reported by: casiepa's profile casiepa Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.0
Component: API - Actions/Filters Keywords: good-first-bug has-patch

Description (last modified by netweb)

Most functions use $args['sep'] to define the separator. However (at least) bbp_list_forums() and bbp_get_admin_repair_tool_overhead_filters() seem to use $args['separator']

Normalization including backward compatibility would be needed.

Attachments (1)

2900.diff (2.3 KB) - added by milindmore22 6 years ago.
added $argssep? with backward compatibility

Download all attachments as: .zip

Change History (7)

#1 @netweb
7 years ago

  • Description modified (diff)
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Under Consideration

#2 @netweb
6 years ago

  • Keywords good-first-bug added
  • Milestone changed from Under Consideration to Future Release
  • Version changed from 2.5.8 to 2.0

Moving to future release to clear up Under Consideration milestone, we can milestone this once it has a patch

6 years ago

added $argssep? with backward compatibility

#3 @milindmore22
6 years ago

  • Keywords has-patch added; needs-patch removed

As this is the first time I am contributing to bbpress please let me know if my patch/method is correct.
many thanks

#4 @netweb
5 years ago

  • Milestone changed from Future Release to 2.6

Sorry for the delay in getting to this @milindmore22 let's take a look and try to sneak this into 2.6

#5 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6628:

Separators: Normalize the sep arguments between functions.

This change also switches bbp_list_forums() to implode() links rather than concatenate the same $output string with an increasing number of items. This has the positive side-effect of moving the forum separator (a comma by default) out of individual links.

Props milindmore22. Fixes #2900.

This ticket was mentioned in Slack in #bbpress by casiepa. View the logs.

5 years ago

Note: See TracTickets for help on using tickets.