Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 9 months ago

#2884 closed defect (fixed)

Fix readme issue

Reported by: ramiy Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Locale - i18n/l10n Keywords: has-screenshots has-patch commit
Cc:

Description

The readme file uses markup to create lists. Seems like bbpress uses wrong markup to present lists. See the attached screenshot.

I know that the readme file is changed, and the screenshot does not represent the new readme, but even in the new file the markup is still wrong. I'm attaching a patch to fix the error.

Attachments (2)

2884-bbpress-readme-issue.png (118.5 KB) - added by ramiy 4 years ago.
2884-bbpress-readme-fix.patch (804 bytes) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #bbpress by ramiy. View the logs.


4 years ago

#3 @Otto42
4 years ago

The markdown parser does not understand 5a and 5b. It's trying to parse that as an ordered list. In the example readme.txt, all those are numbered simply "1." for this reason, the markdown parser handles the numbering.

https://wordpress.org/plugins/about/readme.txt

#4 @thebrandonallen
4 years ago

  • Component changed from General to Locale - i18n/l10n
  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6

#5 @netweb
4 years ago

In 5938:

Update readme.txt installation steps with correctly formatted markdown. (trunk)

This changeset fixes an issue where incorrectly formatted markdown list items would not display as expected in the w.org plugin readme.

Props ramiy. See #2884

#6 @netweb
4 years ago

In 5939:

Update readme.txt installation steps with correctly formatted markdown. (2.5 branch)

This changeset fixes an issue where incorrectly formatted markdown list items would not display as expected in the w.org plugin readme.

Props ramiy. See #2884

#7 @netweb
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I've also bumped the readme.txt for the bbPress repo on plugins.svn.wordpress.org for both "stable" and "dev":

This should make these updated strings available for translation shortly Ramiy:

Thanks for this Ramiy, I think everything is done here, marking as fixed.

#8 @johnjamesjacoby
9 months ago

Assigning all closed & unassigned tickets in the 2.6 milestone to myself.

Note: See TracTickets for help on using tickets.