Improve user role listing in WordPress 4.4

[johnbillion]

In WordPress 4.4, if a user has multiple roles then all of these roles will be shown in a comma separated list on the Users admin listing screen. See ​https://core.trac.wordpress.org/ticket/22959.

bbPress assigns multiple roles to users, and also handles this on the Users admin listing screen. The following example code shows how bbPress can prevent the duplicate role name from appearing here, using the new get_role_list filter:

add_filter( 'get_role_list', function( $roles, $user ) {
	$bbp_role = bbp_get_user_role( $user->ID );
	if ( $bbp_role ) {
		unset( $roles[ $bbp_role ] );
	}
	return $roles;
}, 10, 2 );

[netweb]

Thanks John

[tharsheblows]

Thank you!

Looking at the layouts, it'd make sense to not include those custom bbPress columns in WordPress >= 4.4 and use the default roles column in the user list table instead. It's clearer which roles a user has and the table works a bit better on narrower screens.

[tharsheblows]

disable custom roles columns in user list table if WP >= 4.4

[netweb]

Thanks for the patch @tharsheblows, let's try out this new keyword, needs-screenshots ;)

[tharsheblows]

Here you go! :) These are just under 1100px.

​https://cloudup.com/c4vITmExfGv

[johnbillion]

Might want to use version_compare() for complete compatibility with beta versions, etc.

[tharsheblows]

That makes sense! I think this will correctly pick up all 4.4s and no 4.3s but let me know if that's not the way to do it. Thanks.

[tharsheblows]

add in version_compare

[netweb]

Narrow screenshots:

Left: WP /trunk & bbPress unpatched

Middle: WP /trunk & bbPress 2874.1.diff​

Right: WP /trunk & John's filter from above

My one concern here is determining who actually owns each role (it was also my concern for the original upstream WordPress ticket), if a custom bbPress role Recipe contributor was added for users of the food forum how is that differentiated from another role similarly named?

We're also not proposing removing the Change forum role to… dropdown action

I personally like the way it has always been, which is aka the screen on the right but I'd love to hear others opinions?

[thebrandonallen]

@netweb I like the right as well. Do you have a patch lying around, or should I work one up?

[netweb]

Replying to thebrandonallen:

@netweb I like the right as well. Do you have a patch lying around, or should I work one up?

There is now, see 2874.2.diff​

[thebrandonallen]

👍

[netweb]

In 6051:

Introduce bbp_get_major_wp_version() function to help checking against WordPress versions

See #2874

[netweb]

In 6052:

Administration: Only display bbPress users role in bbPress' "Forum Role" list

Since WordPress 4.4 users with multiple roles are displayed in WordPress' "Site Role" list, this changeset ensures bbPress' roles are only displayed under the "Forum Role" list and not duplicated in the "Site Role" list of the users list table.

Props johnbillion, tharsheblows for initial patches
Fixes #2874

[johnjamesjacoby]

Crap. I accidentally stomped r6052.

[johnjamesjacoby]

Fixed again in r6057.