Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

#2855 closed defect (bug) (fixed)

Clear topic favoriters cache when user adds/removes favorite

Reported by: thebrandonallen Owned by: netweb
Priority: normal Milestone: 2.6
Component: API - Cache Version: 2.5.8
Severity: normal Keywords: has-patch
Cc:

Description

Started writing tests for #2488 and realized that I couldn't reliably test the removing of favorites and subscriptions without first testing that the functions to remove favorites and subscriptions actually work as expected. They do, except for cache clearing when adding/removing favorites.

Attachments (1)

2855.1.patch​ (25.9 KB ) - added by thebrandonallen 11 years ago.

Download all attachments as: .zip

Change History (5)

@thebrandonallen
11 years ago

#2 @johnjamesjacoby
11 years ago

In 5926:

Favorites: Purge cache when adding/removing a favorite.

This changeset fixes a bug where cache was not busted, causing incorrect results to be returned & displayed.

Props thebrandonallen. See #2855.

#3 @johnjamesjacoby
11 years ago

I couldn't get the remaining portion of the patch to apply to the Subversion repository, so they'll need to be applied separately later.

#4 @netweb
11 years ago

  • Owner set to netweb
  • Resolution → fixed
  • Status new → closed

In 5928:

Tests: User subscription and user favorites tests in BBP_Tests_Users_Functions_Subscriptions and BBP_Tests_Users_Functions_Favorites

Props thebrandonallen. Fixes #2855.

Note: See TracTickets for help on using tickets.