Skip to:

Opened 9 years ago

Closed 8 years ago

#2852 closed defect (bug) (fixed)

i18n: Phrase like "Your Profile" should be one complete string

Reported by: nao's profile Nao Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: minor Version: 2.5.8
Component: Locale - i18n/l10n Keywords: has-patch commit


In includes/common/template.php, there are some split phrases that are not translatable in some languages where word order is not the same as English.

  • Your & %s's
  • %s Topics, %s Replies, %s Favorites,%s Subscriptions, and %s Profile

These should be combined to form complete phrases.

Attachments (1)

bbpress-2852.patch (3.0 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (9)

#1 @thebrandonallen
9 years ago

  • Keywords reporter-feedback added

Do you have suggestions on how we can make this better for you? I believe most of the people actively developing bbPress are native English speakers.

We could combine "Your Topics," "Your Replies," etc., into full strings, but, ultimately, you'll still end up with "%s Topics," "%s Replies," etc., for cases where a user is viewing another user's profile. This may be exactly what you're looking to get.

#2 @netweb
9 years ago

  • Milestone changed from Awaiting Review to Under Consideration

This ticket was mentioned in Slack in #forums by netweb. View the logs.

8 years ago

#4 @netweb
8 years ago

  • Milestone changed from Under Consideration to 2.6

#5 @SergeyBiryukov
8 years ago

  • Keywords has-patch added; needs-patch reporter-feedback removed

This ticket was mentioned in Slack in #forums by sergey. View the logs.

8 years ago

#7 @SergeyBiryukov
8 years ago

  • Keywords commit added

#8 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 6097:

Common: Improve title output strings for friendlier i18n.

Props @SergeyBiryukov. Fixes #2852.

Note: See TracTickets for help on using tickets.