Skip to:
Content

bbPress.org

Opened 4 years ago

Closed 20 months ago

#2851 closed defect (fixed)

Widgets should not use placeholder-only translations

Reported by: netweb Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.2
Component: API - Widgets Keywords: commit
Cc:

Change History (3)

#1 @hardeepasrani
2 years ago

How would we go about fixing this?

Instead of

<?php printf( esc_html_x( 'by %1$s', 'widgets', 'bbpress' ), '<span class="topic-author">' . $author_link . '</span>' ); ?>

Something like this:

<?php esc_html_x( 'by', 'widgets', 'bbpress' ); ?> <span class="topic-author"><?php echo $author_link; ?></span>

#2 @johnjamesjacoby
20 months ago

  • Keywords commit added; needs-patch removed
  • Milestone changed from Under Consideration to 2.6
  • Owner set to johnjamesjacoby

#3 @johnjamesjacoby
20 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 6813:

Widgets: remove translation strings that only had placeholders in them.

This change also switches output for the reply date option from div to time elements.

Fixes #2851.

Note: See TracTickets for help on using tickets.