Opened 10 years ago
Closed 8 years ago
#2794 closed enhancement (fixed)
Add BP dynamic activity actions
Reported by: | thebrandonallen | Owned by: | johnjamesjacoby |
---|---|---|---|
Milestone: | 2.6 | Priority: | high |
Severity: | normal | Version: | 2.2 |
Component: | Extend - BuddyPress | Keywords: | has-patch |
Cc: |
Description
Included patch adds dynamic activity actions for site wide/group forums. Also includes fix for #2690 by @r-a-y.
Attachments (6)
Change History (19)
#1
@
9 years ago
- Keywords needs-testing needs-docs added
- Owner set to johnjamesjacoby
- Priority changed from normal to high
This ticket was mentioned in Slack in #bbpress by thebrandonallen. View the logs.
9 years ago
#6
@
8 years ago
Patch isn't applying cleanly for me. A refresh would be helpful, or else I'll circle back to this during beta.
#8
@
8 years ago
For some reason, src/includes/extend/buddypress/activity.php
still gets skipped.
I'll apply it manually and review that way.
#9
@
8 years ago
The problem here is that BuddyPress doesn't support filtering of activity items by both component & action.
Because bbPress uses the same action for both group & site-wide forums, this results in duplicate items in the activity drop-down filters (both theme-side and admin-side.)
I'll modify this a bit, and we'll need to also modify BuddyPress if we want this to work differently upstream.
This ticket was mentioned in Slack in #bbpress by netweb. View the logs.
8 years ago
#13
@
8 years ago
- Resolution set to fixed
- Status changed from new to closed
Pretty sure this is as fixed as we can make it, without a change to BuddyPress.
Closing for the 2.6 milestone. Further enhancements or bugs should be new tickets.
Thanks everyone!
Updating patch and adding tests.