Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2738 closed defect (bug) (fixed)

Remove banners added to minified CSS files

Reported by: netweb's profile netweb Owned by: netweb's profile netweb
Milestone: 2.6 Priority: normal
Severity: major Version: trunk
Component: Tools - Build Keywords: needs-patch
Cc:

Description (last modified by netweb)

The banner option was removed from grunt-contrib-cssmin in v0.11.0 (​upstream change here)

See ​#WP30666

Change History (9)

#1 @netweb
10 years ago

In 5586:
Add grunt-banner to replace deprecated banners in cssmin

See #2738.

#2 @netweb
10 years ago

  • Description modified (diff)

#3 @netweb
10 years ago

  • Component changed from General to Tools - Build
  • Severity changed from normal to major

#4 @johnjamesjacoby
10 years ago

  • Owner set to netweb

What's left to do here?

#5 @johnjamesjacoby
10 years ago

  • Keywords commit added

#6 @netweb
10 years ago

  • Keywords needs-patch added; commit removed

Will get to this and a couple of other outstanding Grunt issues later today...

#7 @netweb
10 years ago

  • Description modified (diff)
  • Summary changed from Use grunt-banner to replace deprecated banners in cssmin to Remove banners added to minified CSS files

We can add banners back in a future release using either:

#8 @netweb
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5912:

Tools: Remove banners added to minified CSS files and simplified JS banner

This changeset removes the banners that were previously added to minified CSS files as grunt-contrib-cssmin deprecated this in v0.11.0.

The banner added to minified JS files has also been simplified by removing the time/date so that unnecessarily merges/updates do not trigger unneeded changes when using version control. The banner added to minified JS files is now static without the date/time, this fixes an issue where the minified file would always change because of the compiled date/time even when there were no code changes, this was causing unneeded changes when merging/updating when using version control external to bbPress.

Props netweb. Fixes #2738

#9 @netweb
10 years ago

In 5913:

Tools: Update grunt-contrib-cssmin to v0.13.0

Changelog: ​https://github.com/gruntjs/grunt-contrib-cssmin/compare/v0.11.0...v0.13.0

Testing grunt cssmin and related bbPress Grunt tasks show no issues with grunt-contrib-cssmin

Note: Requires npm install to update dependencies

See #2738

Note: See TracTickets for help on using tickets.