`BBP_Forums_Group_Extension::display()` should take `$group_id` param

[boonebgorges]

See ​https://buddypress.trac.wordpress.org/ticket/5533#comment:7. PHP notices will be thrown in strict mode if the class definition doesn't match the parent. (Sorry :) ) Patch attached.

[netweb]

Thanks Boone :)

[johnjamesjacoby]

In 5560:

Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.

[danbp]

Just to inform you that this patch is not in 2.5.5 !

​https://bbpress.trac.wordpress.org/browser/tags/2.5.5/includes/extend/buddypress/groups.php#L151

[johnjamesjacoby]

Replying to danbp:

Just to inform you that this patch is not in 2.5.5 !

​https://bbpress.trac.wordpress.org/browser/tags/2.5.5/includes/extend/buddypress/groups.php#L151

Correct. This ticket is in the 2.6 milestone. Just like with BuddyPress & WordPress, x.x.x releases are reserved for relatively critical bug fixes to the x.x branch.

[danbp]

Thank you @jjj, but sorry to come back to tell that the notice is still there after patching.

WP 4.1.1
BP 2.2.1
bbP 2.5.5
Theme Twenty Twelve
PHP 5.5.12

[johnjamesjacoby]

You are correct. The fix was not applied to the 2.5 branch of code, so no fix was packaged into 2.5.5. It is in trunk, and will be in 2.6.

[netweb]

Setting this back to fixed again, as noted above these changes are in the 2.6 branch.

[netweb]

This was added to the 2.5 branch in r5807 and will ship as part of bbPress 2.5.8