Skip to:
Content

bbPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 months ago

#2714 closed defect (fixed)

Remove tabindex attribute from form fields and submit buttons

Reported by: joedolson Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: trunk
Component: General - Accessibility Keywords: has-patch
Cc:

Description

bbPress makes heavy use of tabindex attributes throughout forms. Although it uses a tabindex function to increment that tabindex so that the forms may be internally consisten, tabindex is only valid if all focusable elements on the page have appropriate sequential indices.

Since browser automatically generate a tabindex that follows the code order, 99% of positive-value tabindex attributes serve only to make keyboard accessibility more confusing and reduces the accessibility of the application significantly.

Patch removes all tabindex attributes and the associated functions.

Attachments (1)

2714.patch (49.5 KB) - added by joedolson 5 years ago.
Remove all tabindex attributes

Download all attachments as: .zip

Change History (7)

@joedolson
5 years ago

Remove all tabindex attributes

#1 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5561:

Deprecate tabindex functions and their usages. Props joedolson. Fixes #2714.

#2 @johnjamesjacoby
5 years ago

In 5562:

Missed removing a tabindex usage. See #2714.

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.


5 years ago

#5 @netweb
5 years ago

  • Milestone changed from Awaiting Review to 2.6

#6 @joedolson
3 months ago

Is 2.6 ever going to release? Can this be backported to the 2.5 version?

Note: See TracTickets for help on using tickets.