Topics and Replies Pagination issue when pages are > 9 using default permalinks

[igmoweb]

Hi.

When permalinks are deactivated and pagination is generated in bbp_has_replies() function. In line number 273, file includes/replies/template.php we can see the following code:

$bbp->reply_query->pagination_links = str_replace( '&paged=1', '', $bbp->reply_query->pagination_links );

When pages are > 9, they are replaced also by nothing.

Here's the result for one of my links:
​http://www.nlhvnlv.dev/?topic=sus-preguntas&paged=9 (page 9, that's fine)
​http://www.nlhvnlv.dev/?topic=sus-preguntas0 (page 10)
​http://www.nlhvnlv.dev/?topic=sus-preguntas0 (page 11)

Sorry, my forum is private so you won't have access.

I think this should be high priority. It should be easy to fix though as we could leave the paged arg in the first page link and yet is ugly it still work.

Or... we could use a regexp instead.

[netweb]

Thanks, makes sense in that we should not be doing that, will get this fixed for the next release.

Related: #2468 #2556

[igmoweb]

Thanks netweb!

I don't have much time right now to provide a patch but I'll see if I can :)

[tharsheblows]

Um, I'm just deleting the post where I said "I'm obviously missing something" because I was... :) I will try to submit a patch for this one, too.

[tharsheblows]

don't replace paged=1 in eg paged=14

[netweb]

In 2702.2.diff, added code for topics based of 2702.diff.

I'm just refreshing my test site with some demo content and will test shortly.

[tharsheblows]

I clearly have some sort of block about remembering to check topics for the issues that affect replies, sorry. This one got a little twisted around in my head at the time, so if it doesn't work I can take another look if you'd rather not.

[johnjamesjacoby]

Patch isn't working for me, and the regular expression doesn't look right to me.

Any other eyes on this?

[netweb]

Before patch

Page 1 - ​http://src.wordpress-develop.dev/?topic=2702
Page 2 - ​http://src.wordpress-develop.dev/?topic=2702&paged=2
Page 14 - ​http://src.wordpress-develop.dev/?topic=27024

After applying patch

Page 1 - ​http://src.wordpress-develop.dev/?topic=2702
Page 2 - ​http://src.wordpress-develop.dev/?topic=2702&paged=2
Page 14 - ​http://src.wordpress-develop.dev/?topic=2702&paged=14

[johnjamesjacoby]

Thanks; will test again in my AM.

The other nit is that we can't use anonymous functions until PHP5.3, so we'll need an actual callback function instead.

[tharsheblows]

unit tests for replies and topics pagination

[tharsheblows]

Unit tests for topics and replies pagination. I will change the anonymous functions too, just keep forgetting.

[tharsheblows]

This has the patches with the named function and unit tests.

[tharsheblows]

replies and topic pagination patches and unit tests

[thebrandonallen]

Updated patch to use preg_replace instead of preg_replace_callback. Also, added search pagination links.

[johnjamesjacoby]

In 6228:

Pagination: Use preg_replace to find & remove page=1 query arguments.

Fixes #2702. Props thebrandonallen, tharsheblows.