Skip to:
Content

bbPress.org

Opened 5 years ago

Last modified 12 days ago

#2649 reopened defect

Repair tools should also repair/recount sub forum count meta

Reported by: netweb Owned by:
Milestone: Priority: normal
Severity: major Version: trunk
Component: Tools Keywords:
Cc: GDragoN

Description

Currently the repair tools do not repair/recount _bbp_forum_subforum_count counts.

To ensure the accuracy/integrity of our forum meta we should do this.

The most common occurrence of forums not having this meta data is if the forums were imported.

Change History (2)

#1 @netweb
5 years ago

  • Keywords needs-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Closing as worksforme, _bbp_forum_subforum_count is actually recalculated when the repair tool "Recalculate last activity in each topic and forum" (bbp_admin_repair_freshness()) as part of bbp_update_forum()

#2 @GDragoN
12 days ago

  • Cc GDragoN added
  • Resolution worksforme deleted
  • Severity changed from normal to major
  • Status changed from closed to reopened
  • Version set to trunk

This recalculation is technically incorrect. This takes into account only public forums, ignoring private and hidden. Both private and hidden should be counted, especially when most forums require users to be logged in, and private forums are visible in such case.

Or, include three values: _bbp_forum_subforum_count, _bbp_forum_subforum_private_count, _bbp_forum_subforum_hidden_count.

Note: See TracTickets for help on using tickets.