Skip to:
Content

bbPress.org

Opened 5 years ago

Last modified 4 years ago

#2638 new defect

Accessibility: Template Forms - textarea's should use aria-label

Reported by: netweb Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: General - Accessibility Keywords:
Cc:

Description

via Karl Groves bbPress Accessibility Feedback https://gist.github.com/ntwb/c8f99df8a714ed028e2d

Aria-label used here, too. No real need for a visual label

Proposed:

<textarea class="bbp-the-content wp-editor-area" rows="12" cols="40" 
name="bbp_topic_content" id="bbp_topic_content" aria-label="Topic Content"></textarea>

Current:

<textarea class="bbp-the-content wp-editor-area" rows="12" cols="40" 
name="bbp_topic_content" id="bbp_topic_content"></textarea>

Change History (3)

#1 @johnjamesjacoby
5 years ago

  • Component changed from Theme Compatability to Accessibility
  • Milestone changed from Awaiting Review to 2.7

Bumping to 2.7 so we can clear out Awaiting Review and 2.6 milestones.

#2 @johnjamesjacoby
5 years ago

  • Milestone changed from 2.7 to 2.8

Bumping all 2.7 to 2.8 milestone.

#3 @netweb
4 years ago

Related: #WP31522 Quicktags: use aria-label to improve accessibility

WordPress core added aria-labels to quicktags in r32883

Before:

<div id="qt_bbp_reply_content_toolbar" class="quicktags-toolbar">
    <input type="button" id="qt_bbp_reply_content_strong" class="ed_button button button-small" value="b">
    <input type="button" id="qt_bbp_reply_content_em" class="ed_button button button-small" value="i">
    <input type="button" id="qt_bbp_reply_content_link" class="ed_button button button-small" value="link">
    <input type="button" id="qt_bbp_reply_content_block" class="ed_button button button-small" value="b-quote">
    <input type="button" id="qt_bbp_reply_content_del" class="ed_button button button-small" value="del">
    <input type="button" id="qt_bbp_reply_content_img" class="ed_button button button-small" value="img">
    <input type="button" id="qt_bbp_reply_content_ul" class="ed_button button button-small" value="ul">
    <input type="button" id="qt_bbp_reply_content_ol" class="ed_button button button-small" value="ol">
    <input type="button" id="qt_bbp_reply_content_li" class="ed_button button button-small" value="li">
    <input type="button" id="qt_bbp_reply_content_code" class="ed_button button button-small" value="code">
    <input type="button" id="qt_bbp_reply_content_close" class="ed_button button button-small" title="Close all open tags" value="close tags">
</div>

After:

<div id="qt_bbp_reply_content_toolbar" class="quicktags-toolbar">
    <input type="button" id="qt_bbp_reply_content_strong" class="ed_button button button-small" aria-label="Bold" value="b">
    <input type="button" id="qt_bbp_reply_content_em" class="ed_button button button-small" aria-label="Italic" value="i">
    <input type="button" id="qt_bbp_reply_content_link" class="ed_button button button-small" aria-label="Insert link" value="link">
    <input type="button" id="qt_bbp_reply_content_block" class="ed_button button button-small" aria-label="Blockquote" value="b-quote">
    <input type="button" id="qt_bbp_reply_content_del" class="ed_button button button-small" aria-label="Deleted text (strikethrough)" value="del">
    <input type="button" id="qt_bbp_reply_content_img" class="ed_button button button-small" aria-label="Insert image" value="img">
    <input type="button" id="qt_bbp_reply_content_ul" class="ed_button button button-small" aria-label="Bulleted list" value="ul">
    <input type="button" id="qt_bbp_reply_content_ol" class="ed_button button button-small" aria-label="Numbered list" value="ol">
    <input type="button" id="qt_bbp_reply_content_li" class="ed_button button button-small" aria-label="List item" value="li">
    <input type="button" id="qt_bbp_reply_content_code" class="ed_button button button-small" value="code">
    <input type="button" id="qt_bbp_reply_content_close" class="ed_button button button-small" title="Close all open tags" value="close tags">
</div>

Both these qt_bbp_reply_content_code and qt_bbp_reply_content_close quicktags do NOT have an aria-label per the code posted above, should investigate this at the same time.

Note: See TracTickets for help on using tickets.