Accessibility: Tabindex – Remove all instances of tab index from bbPress

[netweb]

via Karl Groves bbPress Accessibility Feedback ​https://gist.github.com/ntwb/c8f99df8a714ed028e2d

Eliminate tabindex in any case where it is > 0

They almost always result in decreased accessibility. Even when implemented properly (which is rare), they are typically used to account for poor design decisions. For instance, the natural navigation order is illogical, so tabindex is used to fix it. Or search is not prevalent within the page, so accesskey is implemented to provide quicker access to it. The benefits of accesskey and tabindex rarely outweigh the problems they introduce.

Related: ​#WP19930 tabindex ​does not help accessibility at all.

[netweb]

In 2633.diff:

First pass at removing tabindex from bbPress

• Removes all 'tabindex' from template form fields and widgets
• Removes the TinyMCE tabfocus plugin
• Removes jQuery javascript for bbp_topic_title and bbp_topic_tags tab focus

Still a couple of things to do here including depreciate bbp_tab_index() and bbp_get_tab_index()

[netweb]

Via WordPress Theme Accesibility Guidelines ​http://make.wordpress.org/themes/guidelines/guidelines-accessibility/

Not Allowed

• The tabindex attribute, excepting negative or zero tabindex in specific circumstances (assessed on a case-by-case basis).

[johnjamesjacoby]

Bumping to 2.7 so we can clear out Awaiting Review and 2.6 milestones.

[johnjamesjacoby]

Bumping all 2.7 to 2.8 milestone.

[johnjamesjacoby]

Fixed in #2714.

Thanks everyone!