Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

#2623 closed defect (bug) (invalid)

Reply To functions parameter order

Reported by: netweb Owned by:
Priority: high Milestone:
Component: Component - Replies Version: trunk
Severity: major Keywords: needs-testing
Cc:

Description

Reply To's are still not quite behaving correctly when calling bbp_get_reply_to() and bbp_update_reply_to().

We need to ensure passing the correct parameter order in both bbp_get_reply_to() and bbp_update_reply_to() functions so that the reply id is not interchanged for the reply to id.

See also bbp_validate_reply_to()

Attachments (1)

2623.1.diff​ (903 bytes ) - added by netweb 12 years ago.

Download all attachments as: .zip

Change History (5)

@netweb
12 years ago

#1 @netweb
12 years ago

Related: #2528

#2 @johnjamesjacoby
12 years ago

This patch does not seem correct.

  • bbp_update_reply_to()'s return value is never used. If it were, why would it return the same ID being passed into it?
  • Why would bbp_get_reply_to() return the same ID being passed into it? Doesn't it make more sense to return the meta data we're requesting?
Version 0, edited 12 years ago by johnjamesjacoby (next)

This ticket was mentioned in IRC in #bbpress-dev by jjj. ​View the logs.
12 years ago

#4 @netweb
12 years ago

  • Milestone 2.6
  • Resolution → invalid
  • Status new → closed
Note: See TracTickets for help on using tickets.