topic not included when post__not_in is set

[mikelopez]

Hi,

My name is Mike Lopez, Lead Developer for WishList Products.

We have a few clients reporting that bbPress is not displaying the post topic for regular members. We investigated the matter and narrowed the problem to the _bbp_has_replies_where function in bbpress/includes/replies/functions.php in bbPress version 2.5.3

Apparently, the function does not do it's thing if post__not_in is set. I think this issue will also appear if some other plugin specifies a post__not_in, not just WishList Member.

I've attached a patch file for bbpress/includes/replies/functions.php which so far seems to fix the issue. Kindly see if the patch I made will not affect other parts of bbPress. Thus far, I haven't seen any adverse effects but you know your code better.

Thank you very much.

Mike

[mikelopez]

Patch for bbpress/includes/replies/functions.php (version 2.5.3)

[johnjamesjacoby]

In 5476:

In _bbp_has_replies_where() remove the post__not_in check and add extra search/replace arguments for more complex queries. Improves support for popular privacy plugins that frequently use post__not_in. Props mikelopez. Fixes #2609.