Skip to:
Content

bbPress.org

Opened 5 years ago

Last modified 4 years ago

#2602 new defect

Twenty Fourteen Ephemera widget doesn't display audio/video embeds

Reported by: netweb Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Appearance - Theme Compatibility Keywords: has-patch 2nd-opinion
Cc: jjjay@…

Description

Migrated from #WP27986 Ephemera widget does not display audio/video embeds when on a bbPress 'page'

Repro:

  • Add an audio or video post with YouTube, WordPress.TV, Spotify Playlist
  • Add Twenty Fourteen Ephemera widget for post type created above
  • Navigate to bbPress forums http://example.com/forums

Expected results are to see the embeds in the widget just as when viewing the site.

Tested with YouTube, WordPress.TV and Spotify video and audio embeds.

HTML of the widget when viewing a post/page etc:

<article class="post-42481 post type-post status-publish format-audio hentry category-my-category">
        <div class="entry-content">
                <p>
                        <iframe src="https://embed.spotify.com/?uri=spotify:user:1140361011:playlist:49EBwgjV6snwSc1cXz9Cd3" width="300" height="380" frameborder="0" allowtransparency="true"></iframe>
                </p>
        </div>
...

HTML of the widget when viewing a bbPress section:

<article class="post-42481 post type-post status-publish format-audio hentry category-my-category">
        <div class="entry-content">http://open.spotify.com/user/1140361011/playlist/49EBwgjV6snwSc1cXz9Cd3</div>
....

Attachments (2)

27986.png (192.4 KB) - added by netweb 5 years ago.
2602.diff (748 bytes) - added by tharsheblows 5 years ago.
adds back in autoembed filter to the_content

Download all attachments as: .zip

Change History (5)

@netweb
5 years ago

#1 @tharsheblows
5 years ago

  • Cc jjjay@… added

I don't know if this is how you want to go about it and it could be made nicer so it's easier to add in filters that need to be added back in - so take this as a first draft to see if it's working correctly and something like you need. And please oh please tell me if I'm not doing the patches etc correctly sooner rather than later, thanks! :)

@tharsheblows
5 years ago

adds back in autoembed filter to the_content

#2 @tharsheblows
5 years ago

  • Keywords has-patch added; needs-patch removed

Adding in has-patch although I'm not convinced this is quite the right way to do it.

#3 @johnjamesjacoby
4 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from 2.6 to 2.7

If we wait enough years, this problem might go away on its own. :)

I don't really love the approach in this patch, but there may not be a better way.

Do any other themes have similar issues?

Note: See TracTickets for help on using tickets.