Conversion issues SMF to bbPress

[mspecht]

There are two minor issues with the SMF.php importer. &nbsp; and <br> are not being converted correctly.

Lines 722 - 728 instead of :

		// Replace '<br />' with ''
		$SMF_markup = preg_replace( '/\<br \/\>/',   '<tt>',  $SMF_markup );

		// Replace '[size=$1]' with '<span style="font-size:$1%;">$3</span>'
		$SMF_markup = preg_replace( '/\[size=(.*?)\]/', '<span style="font-size:$1">', $SMF_markup );
		// Replace '[/size]' with '</span>'
		$SMF_markup = preg_replace( '/\[\/size\]/',     '</span>',  $SMF_markup );

Needs to be something like:

		// Replace '<br />' with ''
		$SMF_markup = preg_replace( '/\<br \/\>/',   '<br>',  $SMF_markup );

		// Replace '[size=$1]' with '<span style="font-size:$1%;">$3</span>'
		$SMF_markup = preg_replace( '/\[size=(.*?)\]/', '<span style="font-size:$1">', $SMF_markup );
		// Replace '[/size]' with '</span>'
		$SMF_markup = preg_replace( '/\[\/size\]/',     '</span>', $SMF_markup );

		// Replace '&nbsp;' with ' '
		$SMF_markup = preg_replace ( '/&nbsp;/', ' ', $SMF_markup );

[netweb]

Thanks for this, let me know if you find any others and we'll ship this as part of 2.6

[netweb]

In r5332:

SMF Importer BBCode regex expressions

• Fix copy pasta <br>/<tt> regex
• Add non-break space &nbsp; to space rexex
• Props mspecht. Fixes #2558

[johnjamesjacoby]

In 6476:

Converters: Port r5332 to 2.5 branch.

See #2558, #3112.

[johnjamesjacoby]

Assigning all closed & unassigned tickets in the 2.6 milestone to myself.