Use `meta_type` argument in meta queries

[johnjamesjacoby]

​#WP21621 fixed incorrect type casting of meta queries. Because bbPress (currently) uses meta values and queries for things like freshness, casting to DATETIME for date queries and NUMERIC for count/popular queries guarantees accurate results, and comes with a small performance increase as well.

Let's update our queries to add this cast hinting, let it soak in trunk, and see what comes from it.

The main concern I have comes from the additional meta_typeargument possibly interfering with plugins that filter arguments to order by different values. In those cases, it's plausible that we'd be forcing an incorrect type cast to DATETIME when a filter changed the default query order to NUMERIC.

[johnjamesjacoby]

In 5297:

Add meta_type hinting to widget queries. See #2554.

[johnjamesjacoby]

In 5298:

Add meta_type hinting to topics queries. See #2554.

[johnjamesjacoby]

In 5299:

Add meta_type hinting to bbp_update_forum_last_topic_id(). See #2554.

[johnjamesjacoby]

In 5300:

Add meta_type hinting to admin queries. See #2554.

[johnjamesjacoby]

In 5301:

Add meta_type hinting to bbp_move_reply_handler(). See #2554.

[johnjamesjacoby]

In 5302:

Add meta_type to extra page template: page-topics-no-replies.php. See #2554.

[johnjamesjacoby]

Meta type hints are all done. Closing as fixed.

[netweb]

bbPress' registered views slipped past...

Oh bother! No topics were found here!
http://bbpress.org/forums/view/no-replies/ ​http://buddypress.org/support/view/no-replies/

---

In ​2554-register_views.diff:

Add meta_type hinting to register_views().

[johnjamesjacoby]

In 5322:

Add NUMERIC type hinting to view queries. Props netweb. Fixes #2554.