Skip to:
Content

bbPress.org

Opened 6 years ago

Closed 5 years ago

Last modified 3 years ago

#2539 closed defect (fixed)

Grammatical Error on Merge Topic Page

Reported by: gautamgupta Owned by: netweb
Milestone: 2.6 Priority: low
Severity: trivial Version: trunk
Component: Component - Topics Keywords:
Cc:

Description

All replies within both topics will be merged chronologically. The order of the merged replies is based on the time and date they were posted. If the destination topic was created after this one, it's post date will be updated to second earlier than this one.

should read as:

All replies within both the topics will be merged chronologically. The order of the merged replies is based on the time they were posted. If the destination topic was created after this one, its post date will be updated to a second earlier than this one.

Attachments (1)

2539.2.diff (1003 bytes) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in IRC in #bbpress-dev by netweb. View the logs.


6 years ago

#2 @netweb
6 years ago

  • Keywords good-first-bug added
  • Milestone changed from 2.5.4 to 2.6

Putting this in 2.6 milestone to avoid new string translations.

It's in /trunk/templates/default/bbpress/form-topic-merge.php if anyone is up for a 'good-first-bug'

@netweb
5 years ago

#3 @netweb
5 years ago

  • Keywords has-patch added

#4 @netweb
5 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 5354:

Improved topic merge verbiage in form-topic-merge.php template.
Props gautamgupta. Fixes #2539

#5 @johnjamesjacoby
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Still not great, and the first "the" is definitely not grammatically correct. Let's try:

Replies to both topics are merged chronologically, ordered by the time and date they were published. Topics may be updated to a 1 second difference to maintain chronological order based on the merge direction.

Last edited 5 years ago by johnjamesjacoby (previous) (diff)

This ticket was mentioned in IRC in #bbpress-dev by jjj. View the logs.


5 years ago

#7 @netweb
5 years ago

  • Keywords has-patch good-first-bug removed

Cool, now to actually make them do what the verbiage says, details in #2528

#8 @netweb
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5482:

Improved topic merge verbiage in form-topic-merge.php template.
Props johnjamesjacoby. Fixes #2539

#9 @netweb
3 years ago

#3062 was marked as a duplicate

Note: See TracTickets for help on using tickets.