Optimize Repair Tools SQL Queries

[netweb]

Optimize Repair Tools SQL Queries | bbPress -> Tools - Repair Tools

[netweb]

In ​2533.1.diff

Combine existing two SQL queries to a single SQL query for Topics _bbp_last_active_id

Query times based on ~2,500 Topics with ~5,000 replies total ~33% performance increase

Original queries total time - Total Query Time: 180.5ms (Part 1 - 92.1ms & Part 2 88.4ms)

New single query - Total Query Time: 119.0ms*/

[netweb]

Patch for _bbp_last_active_id & _bbp_last_active_time

[netweb]

In ​2533.2.diff added _bbp_last_active_time

Combine existing two SQL queries to a single SQL query for Topics _bbp_last_active_time

Query times based on ~2,500 Topics with ~5,000 replies total ~50% performance increase

Original queries total time - Total Query Time: 95.3ms (Part 1 - 43.9ms & Part 2 51.4ms)

New single query - Total Query Time: 44.5ms*/

[netweb]

In ​2533.3.diff
Fix bbp_admin_repair_topic_voice_count() where the count was including the reply custom post type, causing SQL errors and terminating the function early before the count was completed.

[netweb]

Related: #2353

[netweb]

Moving to 2.6, irrespective of how #1925 is implemented this is good to go.

[netweb]

We should be including bbp_update_topic_anonymous_reply_count() in the repair tool counts.

Will update patch with unit tests ;)

[netweb]

In 5831:

Tests: Add admin tools test test_bbp_admin_repair_topic_voice_count() for bbp_admin_repair_topic_voice_count()

Props netweb. See #2533

[netweb]

Related: #2876

[Destac]

Is there anything left that needs to be done in this ticket other than testing?

[netweb]

Replying to Destac:

Is there anything left that needs to be done in this ticket other than testing?

Yes, the unit test test_bbp_admin_repair_freshness() for bbp_admin_repair_freshness() needs to be created before merging the outstanding patch in 2533.3.diff​

[Destac]

What's the procedure to help with testing i would love to help

[netweb]

Replying to Destac:

What's the procedure to help with testing i would love to help

For this ticket, PHPUnit, it's outlined in the WordPress core handbook:

​https://make.wordpress.org/core/handbook/testing/automated-testing/phpunit/

If this is something you're familiar with then some help would be fantastic.

We also have what we call "Good First Bugs" that are great introductions to contributing, these bugs are a great way to get started, you can see a list of the "open tickets" here: ​https://bbpress.trac.wordpress.org/query?status=!closed&keywords=~good-first-bug

[johnjamesjacoby]

We aren't actually using _bbp_anonymous_reply_count anywhere. Maybe we don't have to?

[johnjamesjacoby]

Bump to 2.7. What's in is good, and what's left doesn't appear critical.

[netweb]

Patch will need a refresh and unit tests, adding some refreshed performance stats would also be nice