Remove the ability to subscribe to 'Forum Categories`

[netweb]

If you subscribe to a forum category you will not receive new topic notifications for any child forums of that category.

Eg. Subscribe to 'Forum Category' you will not recieve new topic notifications from the 'First Child Forum' or 'Second Child Forum' forums.

• Forum Category
  • First Child Forum
  • Second Child Forum

Further down the track this could be implemented so that you could subscribe to categories/parent forums and receive new topic notifications for all child forums.

For now add a bbp_is_forum_category check to bbp_forum_subscription_link in content-single-forum.php template to hide the 'subscribe' link on forum categories.

[johnjamesjacoby]

In 5164:

In bbp_get_forum_subscription_link() do not return a link if viewing a forum category. This is a temporary stop-gap until forums can be subscribed to in a hierarchical manner. Fixes #2475, hat-tip netweb.

[johnjamesjacoby]

In 5165:

Revert part of r5164 that moved the $r array within a bbp_is_forum_category() check in bbp_get_forum_subscription_link(), as it caused debug notices from $r not being defined. See #2475.