Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2474 closed defect (bug) (wontfix)

Improve bbPress compatibility with Jetpack's 'Widget Visibility'

Reported by: sgr33n Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.4.1
Component: API - Widgets Keywords:
Cc: jeherve

Description

Hi,

I'm trying to use the JetPack Widget Visibility option with bbPress, but it's impossibile to identify the first page in order to show some bbPress widget only on it. Even if would be possible to set it as a static page (the one used by bbPress with default guid "forums"), it doesn't recognize it until i deactivate bbPress. For all the other page Jetpack make it possibile to recognize bbPress forums, topics and replies by their different post types, so the only problematic page is the first one. I think this could be a bug because the page with guid "forums" should pass through JetPack Widget Visibility, but when bbPress is active it doesn't recognize it anymore.

Thanks.

Attachments (1)

widget-conditions.php (17.1 KB) - added by SGr33n 8 years ago.
Replace this to add page is bbpress condition

Download all attachments as: .zip

Change History (16)

#1 follow-up: @netweb
8 years ago

  • Summary changed from Impossible to identify the first page of the bbPress forum with "Jetpack Widget Visibility". to Improve bbPress compatibility with Jetpack's 'Widget Visibility'
  • Version changed from 2.1 to 2.4.1

Confirmed, using bbPress with Jetpack's Widget Visibility you are not able to assign widgets to the bbPress root /forums, using a page titled forums or a custom page eg. forumpage using Jetpack's visibilty option post type = forum or page = forums/forumpage etc.

http://example.com/forums <- Standard bbPress - Only Widget Visibility option is if post type = forum does not display any widgets.

http://example.com/forums <- Using a WP page titled forums and bbPress root slug forums using Widget Visibility post type = forum or page = forums does not display any widgets.

http://example.com/forumpage<- Using a WP page titled forumpage and bbPress root slug forumpage using Widget Visibility post type = forum or page = forumpage does not display any widgets.

Single Forums, Topics and Replies appear to work fine, just the root forums page is the issue.

#2 follow-up: @johnjamesjacoby
8 years ago

Any luck with topics views? I suspect any theme comparability page probably has problems as we'll.

#3 in reply to: ↑ 2 @netweb
8 years ago

Replying to johnjamesjacoby:

Any luck with topics views? I suspect any theme comparability page probably has problems as we'll.

Single Forums, Topics and Replies appear to work fine, just the root forums page is the issue.

#4 in reply to: ↑ 1 ; follow-up: @jeherve
8 years ago

  • Cc jeherve added

Replying to netweb:

http://example.com/forums <- Standard bbPress - Only Widget Visibility option is if post type = forum does not display any widgets.

http://example.com/forums <- Using a WP page titled forums and bbPress root slug forums using Widget Visibility post type = forum or page = forums does not display any widgets.

http://example.com/forumpage<- Using a WP page titled forumpage and bbPress root slug forumpage using Widget Visibility post type = forum or page = forumpage does not display any widgets.

I'm not really familiar with bbPress, so you'll excuse me if my question seems stupid.

How would you check for each one of these situations using standard conditional tags, or custom bbPress conditional tags? We might have to customize Jetpack to add bbPress compatibility.

#5 in reply to: ↑ 4 @netweb
8 years ago

Replying to jeherve:

How would you check for each one of these situations using standard conditional tags, or custom bbPress conditional tags? We might have to customize Jetpack to add bbPress compatibility.

is_bbpress() /trunk/includes/common/template-tags.php?rev=4919#L1012

#7 @jeherve
8 years ago

Thanks! I created a ticket in the plugins trac, and we'll see about adding extra checks when bbPress is active:

#8 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.6

#9 @johnjamesjacoby
8 years ago

  • Component changed from General to Widgets
  • Milestone 2.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this here, so we can focus on getting Jetpack to support this with bbPress's conditional tags.

#10 @SGr33n
8 years ago

For the records, I discovered that the forum root is sensitive to visibility "page" is "archive page". Nothing about the two page views links.

#11 @SGr33n
8 years ago

This would solve temporarily the issue.

Replace \wp-content\plugins\jetpack\modules\widget-visibility\widget-conditions.php with the attached one.

Anyway if you used the page is_archive page, as told before, this will affect also the forum root.

@SGr33n
8 years ago

Replace this to add page is bbpress condition

#12 @SGr33n
8 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Started a new ticket.

Last edited 8 years ago by SGr33n (previous) (diff)

#13 @SGr33n
8 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

#15 @SGr33n
8 years ago

I see, but... still waiting :P

Note: See TracTickets for help on using tickets.