Skip to:
Content

bbPress.org

Opened 7 years ago

Closed 6 years ago

#2468 closed defect (fixed)

pagination anchors not working / in place when replying to a topic with >50 pages

Reported by: leanderbraunschweig Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.4.1
Component: Component - Topics Keywords:
Cc: jjjay@…

Description

This is a minor bug I guess, but nonetheless "fix-worthy":

Once a topic passes the threshold of 50 pages users replying will be send to the first page of the topic after their reply instead being (anchor-)redirected to the page where they replied on (= jump to their post).

The URL <50 renders correctly:
../topic/my-topic/page/47/#post-34680

The URL >50 outputs instead:
../topic/my-topic#post-34679
and strips the "page"-part.

If you need more (debug-)info then get in touch.
Thanks & regards,

Henning

Change History (12)

#1 @johnjamesjacoby
7 years ago

  • Milestone changed from Awaiting Review to 2.6

I'll take a look. Thanks for the report.

#2 @johnjamesjacoby
7 years ago

  • Owner set to johnjamesjacoby

#3 @johnjamesjacoby
7 years ago

  • Component changed from General to Topics
  • Keywords reporter-feedback added
  • Milestone changed from 2.6 to Future Release

Tried to duplicate this by ramping the Replies per page down to 2, and was able to post 125 replies with successful redirections.

Moving this into Future Release until we have more information.

#4 @tharsheblows
7 years ago

This is the 1000 posts bug - it has to do with the number of replies, not the number of pages. I didn't see it before posting #2556.

You can see it in the wild here (the top topic):
http://bbpress.org/forums/view/popular/

#5 follow-up: @mouffles
7 years ago

I would like to know when someone will manage with this well known bug, that also affect the bbpress forum, and is easily reproductible.

Indeed it's been years that the long topics of my forum bug as described. :(

#6 @mouffles
7 years ago

1 year later : not resolved. It's an important detail for real users. Please publish a patch or else.

#7 @tharsheblows
7 years ago

  • Cc jjjay@… added

Hi mouffles, I believe this has been fixed -- see here: https://bbpress.trac.wordpress.org/ticket/2556

One thing I had to do was recalculate the menu order (how I did it is in the link above). Test the code first of course, but that might work for you, too.

#8 in reply to: ↑ 5 @johnjamesjacoby
7 years ago

  • Milestone changed from Future Release to 2.6

Replying to mouffles:

I would like to know when someone will manage with this well known bug, that also affect the bbpress forum, and is easily reproductible.

Indeed it's been years that the long topics of my forum bug as described. :(

This was fixed in r5338 on the #2556 ticket as part of a different, more specific issue.

Please publish a patch or else.

Or else... you'll continue making comments other random tickets? :)

Closing this issue as resolved as part of #2556. Thanks for being patient everyone. This will be fixed as part of the 2.6 release.

#9 @mouffles
7 years ago

It works ! Thank you !

#10 @mouffles
7 years ago

tested on 1000 replies topic, patch doesn't work.

bug with long topic redirected after reply to the first page, with a buggy url still present :/

#11 @tharsheblows
7 years ago

Hi mouffles - you're right, this wasn't fixed in 2.5.4, it's scheduled to be fixed in 2.6. The fix is here #2615 . I had to apply this fix then recalculate the menu orders using my plugin to get it all to work correctly - new replies were breaking the menu order.

#12 @netweb
6 years ago

  • Keywords reporter-feedback removed
  • Resolution set to fixed
  • Status changed from new to closed

Marking this as fixed as part of #2556 and #2615

Note: See TracTickets for help on using tickets.