Opened 11 years ago
Closed 11 years ago
#2455 closed defect (bug) (fixed)
BBP_Walker_Reply::start_el() closes element too-early
Reported by: | nikolov.tmw | Owned by: | johnjamesjacoby |
---|---|---|---|
Milestone: | 2.5 | Priority: | normal |
Severity: | normal | Version: | 2.4.1 |
Component: | Component - Replies | Keywords: | has-patch |
Cc: |
Description
The start_el() function should NOT close the element that it's starting(as far as I'm aware).
This should be done by the end_el() function - since when you have multiple levels of content, you want the child elements to be nested under the parent element.
On top of that when you close an element twice - you get a mess of the HTML and there could be issues.
The simple solution is to simply remove the following code:
</<?php echo $tag ?>>
on line 399 in /includes/common/classes.php . I can provide the patch if necessary.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
Nice catch, thanks.