Skip to:
Content

bbPress.org

Opened 7 years ago

Closed 7 years ago

#2455 closed defect (fixed)

BBP_Walker_Reply::start_el() closes element too-early

Reported by: nikolov.tmw Owned by: johnjamesjacoby
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.4.1
Component: Component - Replies Keywords: has-patch
Cc:

Description

The start_el() function should NOT close the element that it's starting(as far as I'm aware).

This should be done by the end_el() function - since when you have multiple levels of content, you want the child elements to be nested under the parent element.

On top of that when you close an element twice - you get a mess of the HTML and there could be issues.

The simple solution is to simply remove the following code:

</<?php echo $tag ?>>

on line 399 in /includes/common/classes.php . I can provide the patch if necessary.

Attachments (1)

2455.diff (337 bytes) - added by netweb 7 years ago.

Download all attachments as: .zip

Change History (3)

@netweb
7 years ago

#1 @netweb
7 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 2.5

Nice catch, thanks.

#2 @johnjamesjacoby
7 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5135:

Remove extraneous closing tag in custom walker start_el() method. Props netweb. Fixes #2455.

Note: See TracTickets for help on using tickets.