Strange behaviors with topic-tag taxonomy

[michelwppi]

After (long) hours of tests with this topic-tag custom taxonomy and others, please find some notes:

Consider topic-tag (bbpress) and another custom taxonomy named here "zone"

for template pages in theme with URI ending by ?topic-tag=tp1 or ?zone=z1

taxonomy-topic-tag.php is well selected but functions inside (is_tax('topic-tag') and is_archive()) don't work and don't return true as in

taxonomy-zone.php (and taxonomy.php) is (are) well selected and functions inside (is_tax('zone') and is_archive) work and return true

taxonomy.php is not selected with topic-tag taxonomy (strange and not coherent in data model :-( )

the $wp_query->is_tax() is not true with topic-tag taxonomy and occurs troubles to manage another function as in custom menu or else in header, sidebar or footer...

Workaround :
$queried_object = $wp_query->get_queried_object(); and $queried_object -> taxonomy which remain coherent.

I don't why and when bbPress reset

is_tax()

to false but it is not robust for data-model ( $queried_object faulty ) and good coding with generic functions. (by example for CMS or with plugin like xili_tidy_tags 1.9 and new grouping features).

M.
Plugins author

Note: I reopen old #1591 to attach this new ticket.

[michelwppi]

concern bbPress 2.4 on WP 3.6.1

[johnjamesjacoby]

Good points. These can likely be adjusted back as part of the bbp_theme_compat_reset_post function.

[johnjamesjacoby]

In 5315:

Set is_tax to true when calling bbp_theme_compaty_reset_post() when viewing/editing a topic-tag. Fixes #2444.