Skip to:
Content

bbPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2429 closed defect (fixed)

Theme compat content replacement in 2.4 does terrible things on edit pages

Reported by: aaclayton Owned by: johnjamesjacoby
Milestone: 2.4.1 Priority: highest
Severity: critical Version: trunk
Component: Appearance - Theme Compatibility Keywords:
Cc:

Description

In my themes I provide custom templating for bbPress. This includes edit pages (single-topic-edit.php and single-reply-edit.php). These templates are being properly loaded by bbPress, however Theme Compatibility content replacement is still being called.

This leads to a situation where, on edit pages, the post content gets replaced with $bbp_shortcodes->display_topic_form(); and $bbp_shortcodes->display_reply_form(); respectively.

When I call bbp_the_content() within my form-topic and form-reply templates, I end up with a form within a form, as the post content has been replaced with an entire edit form.

Attachments (1)

2429.patch (677 bytes) - added by johnjamesjacoby 8 years ago.
Bail out of bbp_template_include_theme_compat() if a root template is already included

Download all attachments as: .zip

Change History (5)

#1 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 2.4.1

Moving to 2.4.1 to investigate asap.

#2 @johnjamesjacoby
8 years ago

Confirmed. Looking into it...

@johnjamesjacoby
8 years ago

Bail out of bbp_template_include_theme_compat() if a root template is already included

#3 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5109:

In bbp_template_include_theme_compat(), bail out early when a root template has already been previously located. Fixes issues with recursive calls to the 'the_content' filter. Fixes #2429. (2.4.1)

#4 @johnjamesjacoby
8 years ago

In 5110:

In bbp_template_include_theme_compat(), bail out early when a root template has already been previously located. Fixes issues with recursive calls to the 'the_content' filter. Fixes #2429. (2.5)

Note: See TracTickets for help on using tickets.