Theme compat content replacement in 2.4 does terrible things on edit pages

[aaclayton]

In my themes I provide custom templating for bbPress. This includes edit pages (single-topic-edit.php and single-reply-edit.php). These templates are being properly loaded by bbPress, however Theme Compatibility content replacement is still being called.

This leads to a situation where, on edit pages, the post content gets replaced with $bbp_shortcodes->display_topic_form(); and $bbp_shortcodes->display_reply_form(); respectively.

When I call bbp_the_content() within my form-topic and form-reply templates, I end up with a form within a form, as the post content has been replaced with an entire edit form.

[johnjamesjacoby]

Moving to 2.4.1 to investigate asap.

[johnjamesjacoby]

Confirmed. Looking into it...

[johnjamesjacoby]

Bail out of bbp_template_include_theme_compat() if a root template is already included

[johnjamesjacoby]

In 5109:

In bbp_template_include_theme_compat(), bail out early when a root template has already been previously located. Fixes issues with recursive calls to the 'the_content' filter. Fixes #2429. (2.4.1)

[johnjamesjacoby]

In 5110:

In bbp_template_include_theme_compat(), bail out early when a root template has already been previously located. Fixes issues with recursive calls to the 'the_content' filter. Fixes #2429. (2.5)